fix: prevent nil pointer dereference in envoyGoFilterOnHttpData#18
Merged
johnlanni merged 1 commit intoenvoy-1.27from Jan 31, 2026
Merged
fix: prevent nil pointer dereference in envoyGoFilterOnHttpData#18johnlanni merged 1 commit intoenvoy-1.27from
johnlanni merged 1 commit intoenvoy-1.27from
Conversation
Replace getState() with getOrCreateState() to handle cases where OnHttpData is called before OnHttpHeader, preventing SIGSEGV panic when s.req is not yet initialized. Fixes: panic: runtime error: invalid memory address or nil pointer dereference
|
CodeReview流程已终止 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
getState()withgetOrCreateState()inenvoyGoFilterOnHttpDatato handle cases where OnHttpData is called before OnHttpHeader.Problem
When
envoyGoFilterOnHttpDatais called beforeenvoyGoFilterOnHttpHeader, thes.reqpointer is not yet initialized, causing a nil pointer dereference panic:Solution
getState(s)togetOrCreateState(s)in line 239getOrCreateStatechecks if the request exists and creates it if needed, preventing the nil pointer accessenvoyGoFilterOnHttpHeaderTesting