fix: prevent nil pointer dereference in envoyGoFilterOnHttpData by johnlanni · Pull Request #17 · higress-group/envoy

johnlanni · 2026-01-31T10:58:52Z

Description

Replace getState() with getOrCreateState() in envoyGoFilterOnHttpData to handle cases where OnHttpData is called before OnHttpHeader.

Problem

When envoyGoFilterOnHttpData is called before envoyGoFilterOnHttpHeader, the s.req pointer is not yet initialized, causing a nil pointer dereference panic:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7fe25dce3faf]

Solution

Changed getState(s) to getOrCreateState(s) in line 239
getOrCreateState checks if the request exists and creates it if needed, preventing the nil pointer access
This matches the pattern already used in envoyGoFilterOnHttpHeader

Testing

Fixes the SIGSEGV panic reported in production logs

Signed-off-by: Ryan Northey <ryan@synca.io>

…lidation are set (envoyproxy#29002) Signed-off-by: Xie Zhihao zhihao.xie@intel.com Commit Message: tls: fix handshake failure when both private key provider and cert validation are set Additional Description: After envoyproxy#24297, when both private key provider and validation are set, e.g., using Envoy as sidecars, handshake may end with SSL internal error and HTTP 503 will return. When both private key provider and validation are set, when the private key provider completed its calculation and resumed the handshake (ssl_do_handshake), an async cert validation will be triggered. If the custom validation is not provided, then the async cert validation will complete in the sync way and resume the handshake again (ssl_do_handshake), which cause the error. Risk Level: Low Testing: Unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Fixes commit 55a4cc7 Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

Backport of envoyproxy#29263 Fixes envoyproxy#28415 This reverts part of envoyproxy#24923 Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Greg Greenway <ggreenway@apple.com>

Signed-off-by: Ryan Northey <ryan@synca.io>

* tools/format: Remove unused script * readme: Update code format commands * bazel/ci: Prevent leaking of build tools into env * mobile/ci: Include format script in CI triggers Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>

Signed-off-by: Ryan Northey <ryan@synca.io>

tools: Add option to skip bazel for format fix Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>

…nvoyproxy#29538) Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: Ryan Northey <ryan@synca.io>

) Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io> Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com> Signed-off-by: spacewander <spacewanderlzx@gmail.com> Signed-off-by: wangkai19 <wangkai19@corp.netease.com> Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Meshkati <meshkat76@gmail.com> Signed-off-by: Michael Sauter <mail@michaelsauter.net> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com> Signed-off-by: Willem Veerman <6502426+willemveerman@users.noreply.github.com> Signed-off-by: duxin <duxin40@gmail.com> Co-authored-by: antJack <52443884+antJack@users.noreply.github.com> Co-authored-by: 罗泽轩 <spacewanderlzx@gmail.com> Co-authored-by: StarryNight <wangkai19@corp.netease.com> Co-authored-by: doujiang24 <doujiang24@gmail.com> Co-authored-by: Seyed Mostafa Meshkati <meshkat76@gmail.com> Co-authored-by: phlax <phlax@users.noreply.github.com> Co-authored-by: Braden Bassingthwaite <bradenbass@gmail.com> Co-authored-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com> Co-authored-by: Willem Veerman <6502426+willemveerman@users.noreply.github.com> Co-authored-by: duxin40 <33946910+duxin40@users.noreply.github.com>

…proxy#38597) (#7) Signed-off-by: François JACQUES <fjacques@murex.com> Co-authored-by: François JACQUES <fjacques@murex.com>

…or handle stream response body, getUpstreamHosts & setUpstreamOverrideHost for self-defined load balance policy (#8)

cherry-pick: envoyproxy@090e73d use directLocalAddress instead of localAddress in LocalPortValueExtractorImpl of srds Link: https://code.alibaba-inc.com/Ingress/envoy/codereview/21602142 * support direct local address * add metrics stats

Signed-off-by: jue-yin <jueyin.hsl@alibaba-inc.com>

Co-authored-by: jueyin.hsl <jueyin.hsl@alibaba-inc.com>

Change-Id: If54bbcd6a39c6ef13243bd2b20c3b2c848f95ae6

Change-Id: Ie2f2feb07941843f202825061f84cb1bf546f098

…16)

Replace getState() with getOrCreateState() to handle cases where OnHttpData is called before OnHttpHeader, preventing SIGSEGV panic when s.req is not yet initialized. Fixes: panic: runtime error: invalid memory address or nil pointer dereference

lingma-agents · 2026-01-31T11:00:21Z

🔍 代码审查进行中

⏳ 正在审查

⏰️ 剩余时间：约需数分钟

🔄 分支流向: fix-nil-pointer-in-onhttpdata ➜ main

📦 提交: 审查当前PR从94a69e5到2b9a4e8的提交。

📒 文件清单 （100 个文件）

✅ 新增: 21 个文件
❌ 删除: 38 个文件
🔄 重命名: 1 个文件
📝 变更: 40 个文件

✅ 新增文件:

.azure-pipelines/ci.yml
.azure-pipelines/docker/clean_docker.sh
.azure-pipelines/docker/create_cache.sh
.azure-pipelines/docker/load_caches.sh
.github/config.yml
.github/workflows/envoy-dependency.yml
.github/workflows/request.yml
.github/workflows/verify-requirements.in
.github/workflows/verify-requirements.txt
api/contrib/envoy/extensions/custom_cluster_plugins/cluster_fallback/v3/BUILD
api/contrib/envoy/extensions/custom_cluster_plugins/cluster_fallback/v3/cluster_fallback.proto
api/contrib/envoy/extensions/filters/http/http_dubbo_transcoder/v3/BUILD
api/contrib/envoy/extensions/filters/http/http_dubbo_transcoder/v3/http_dubbo_transcoder.proto
api/contrib/envoy/extensions/filters/http/llm_inference/v3/BUILD
api/contrib/envoy/extensions/filters/http/llm_inference/v3/llm_inference.proto
api/contrib/envoy/extensions/filters/http/mcp_sse_stateful_session/v3alpha/BUILD
api/contrib/envoy/extensions/filters/http/mcp_sse_stateful_session/v3alpha/mcp_sse_stateful_session.proto
api/contrib/envoy/extensions/http/mcp_sse_stateful_session/envelope/v3alpha/BUILD
api/contrib/envoy/extensions/http/mcp_sse_stateful_session/envelope/v3alpha/envelope.proto
api/contrib/envoy/extensions/upstreams/http/dubbo_tcp/v3/BUILD
api/contrib/envoy/extensions/upstreams/http/dubbo_tcp/v3/tcp_connection_pool.proto

❌ 删除文件:

.azure-pipelines/bazel.yml
.azure-pipelines/docker/load_cache.sh
.azure-pipelines/stage/macos.yml
.azure-pipelines/stage/windows.yml
.github/actions/do_ci/action.yml
.github/actions/env/action.yml
.github/actions/pr_notifier/pr_notifier.py
.github/actions/pr_notifier/requirements.in
.github/actions/pr_notifier/requirements.txt
.github/actions/publish/release/setup/action.yml
.github/actions/verify/examples/setup/action.yml
.github/workflows/_cache_docker.yml
.github/workflows/_ci.yml
.github/workflows/_env.yml
.github/workflows/_stage_publish.yml
.github/workflows/_stage_verify.yml
.github/workflows/_workflow-start.yml
.github/workflows/commands.yml
.github/workflows/envoy-prechecks.yml
.github/workflows/envoy-publish.yml
.github/workflows/mobile-android_build.yml
.github/workflows/mobile-android_tests.yml
.github/workflows/mobile-asan.yml
.github/workflows/mobile-cc_tests.yml
.github/workflows/mobile-compile_time_options.yml
.github/workflows/mobile-core.yml
.github/workflows/mobile-coverage.yml
.github/workflows/mobile-docs.yml
.github/workflows/mobile-format.yml
.github/workflows/mobile-ios_build.yml
.github/workflows/mobile-ios_tests.yml
.github/workflows/mobile-perf.yml
.github/workflows/mobile-release_validation.yml
.github/workflows/mobile-traffic_director.yml
.github/workflows/mobile-tsan.yml
.github/workflows/mobile_release.yml
.github/workflows/workflow-complete.yml
api/bazel/utils.bzl

🔄 重命名文件:

examples/grpc-bridge/server/kv/go.mod → api/contrib/envoy/extensions/filters/http/mcp_proxy/BUILD

📝 变更文件:

.azure-pipelines/cached.yml
.azure-pipelines/docker/prepare_cache.sh
.azure-pipelines/docker/prime_cache.sh
.azure-pipelines/docker/save_cache.sh
.azure-pipelines/env.yml
.azure-pipelines/pipelines.yml
.azure-pipelines/stage/checks.yml
.azure-pipelines/stage/linux.yml
.azure-pipelines/stage/prechecks.yml
.azure-pipelines/stage/publish.yml
.azure-pipelines/stage/verify.yml
.azure-pipelines/stages.yml
.bazelrc
.bazelversion
.devcontainer/Dockerfile
.devcontainer/setup.sh
.github/dependabot.yml
.github/workflows/POLICY.md
.github/workflows/check-deps.yml
.github/workflows/pr_notifier.yml
.github/workflows/stale.yml
.gitignore
BUILD
CODEOWNERS
VERSION.txt
api/BUILD
api/CONTRIBUTING.md
api/bazel/BUILD
api/bazel/repositories.bzl
api/bazel/repository_locations.bzl
api/envoy/api/v2/core/health_check.proto
api/envoy/config/core/v3/health_check.proto
api/envoy/config/filter/http/jwt_authn/v2alpha/config.proto
api/envoy/config/listener/v3/listener_components.proto
api/envoy/config/route/v3/route_components.proto
api/envoy/extensions/filters/http/composite/v3/composite.proto
api/envoy/extensions/filters/http/custom_response/v3/custom_response.proto
api/envoy/extensions/filters/http/jwt_authn/v3/config.proto
api/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto
api/envoy/extensions/http/custom_response/redirect_policy/v3/redirect_policy.proto

johnlanni · 2026-01-31T11:00:37Z

Closing - wrong base branch. Will reopen with correct base.

lingma-agents · 2026-01-31T11:00:40Z

CodeReview流程已终止

phlax and others added 30 commits August 22, 2023 19:44

coverage/ci: Enable/fix BEP/BES (envoyproxy#29134)

a06a222

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/checks: Use self-hosted x64 small VMs (envoyproxy#29177)

8a56d95

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/verify: Use bazel.yml (envoyproxy#29189)

c228b22

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/publish: Fix for cache load (envoyproxy#29192)

51976f5

Signed-off-by: Ryan Northey <ryan@synca.io>

tls: Remove additional tracking on SSL_ERROR_SYSCALL

47297e2

Backport of envoyproxy#29263 Fixes envoyproxy#28415 This reverts part of envoyproxy#24923 Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Greg Greenway <ggreenway@apple.com>

ci/x64: Use small VM for x64 build (envoyproxy#29190)

e835178

Signed-off-by: Ryan Northey <ryan@synca.io>

mac/ci: Dont reinstall bazelisk (envoyproxy#29307)

9bca187

Signed-off-by: Ryan Northey <ryan@synca.io>

azp/ci: Use ms-hosted agents for confirmation (envoyproxy#29248)

82f2119

Signed-off-by: Ryan Northey <ryan@synca.io>

azp/ci: Prevent empty uploads (envoyproxy#29246)

31e0237

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/github: Use diskspace hack from toolshed (envoyproxy#29271)

2532d7d

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/windows: Fix cache key (envoyproxy#29274)

d32d608

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/checks: Increase concurrency (envoyproxy#29378)

48134a7

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/format: Bazelify check_format script (envoyproxy#29397)

f8a08c8

Signed-off-by: Ryan Northey <ryan@synca.io>

deps: Bump rules_rust -> 0.27.0 (envoyproxy#29412)

ad6cdcb

Signed-off-by: Ryan Northey <ryan@synca.io>

deps: Bump buildifier/buildozer -> 6.3.3 (envoyproxy#29405)

5c08e3d

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/cache: Use .bazelrc for docker cache key (envoyproxy#29492)

fda5e0b

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/cache: Fix cache priming for Docker only (envoyproxy#29494)

9e9c1ab

Signed-off-by: Ryan Northey <ryan@synca.io>

mac/ci: Retry flakey bazel invokation (envoyproxy#29525)

b143955

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/caching: Optimize bazel cache/fetch (envoyproxy#28977)

4630d35

Signed-off-by: Ryan Northey <ryan@synca.io>

tools/ci: Optimize local formatter (envoyproxy#29521)

336053f

Signed-off-by: Ryan Northey <ryan@synca.io>

deps/tooling: Bump envoy.code.check -> 0.5.5 (envoyproxy#29488)

c8e3c89

Signed-off-by: Ryan Northey <ryan@synca.io>

tools: Add option to skip bazel for format fix (envoyproxy#29528)

0c494cc

tools: Add option to skip bazel for format fix Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>

code/format: Fix/update and shift owner checks -> envoy.code.check (e…

286dbe7

…nvoyproxy#29538) Signed-off-by: Ryan Northey <ryan@synca.io>

clang/tools: Use python distributed versions (envoyproxy#29455)

d7fa856

Signed-off-by: Ryan Northey <ryan@synca.io>

ci/cache: Optimize per-job caching (envoyproxy#29587)

c3b9d8e

Signed-off-by: Ryan Northey <ryan@synca.io>

tools/format: Minor improvement for err handling (envoyproxy#29623)

96ca0dd

Signed-off-by: Ryan Northey <ryan@synca.io>

git/hooks: Use envoy.code.check (envoyproxy#29605)

3edc204

Signed-off-by: Ryan Northey <ryan@synca.io>

fix push hook to use the new bazel-y check format call (envoyproxy#29458

3ddb60b

) Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io> Signed-off-by: Ryan Northey <ryan@synca.io>

johnlanni and others added 26 commits March 25, 2025 21:31

Update wasm cpp host (#6)

317f5e8

golang: add callback method for http plugin config destruction (envoy…

3d93dd6

…proxy#38597) (#7) Signed-off-by: François JACQUES <fjacques@murex.com> Co-authored-by: François JACQUES <fjacques@murex.com>

update proxy-wasm-cpp-host

db29144

fix poll_oneof in wasm host

a2c5a07

fix go runtime gc

e114a74

Remove restricted callback limitations during malloc

cd0c7a9

fix version typo

80f354c

fix golang-filter crash

17cf01d

update proxy wasm cpp host commit

70e1ac0

fix golang filter

cf96e87

fix typo

2c55678

[feature] extend wasm abi, includes: injectEncodedDataToFilterChain f…

b37a298

…or handle stream response body, getUpstreamHosts & setUpstreamOverrideHost for self-defined load balance policy (#8)

add wasm abi: injectEncodedDataToFilterChainOnHeader (#9)

9917bb9

bugfix (#10)

583feb5

support direct local address

916bc62

cherry-pick: envoyproxy@090e73d use directLocalAddress instead of localAddress in LocalPortValueExtractorImpl of srds Link: https://code.alibaba-inc.com/Ingress/envoy/codereview/21602142 * support direct local address * add metrics stats

update proxy wasm cpp host version (#11)

e270725

remove non-existent stats

1caa118

mcp sse stateful session in contrib (#12)

bd693d6

Signed-off-by: jue-yin <jueyin.hsl@alibaba-inc.com>

fix typo

7f18940

Misc optimize (#14)

f16899c

Co-authored-by: jueyin.hsl <jueyin.hsl@alibaba-inc.com>

fix typo

c6084ed

Change-Id: If54bbcd6a39c6ef13243bd2b20c3b2c848f95ae6

update proxy-wasm-cpp-host version

2f61478

Change-Id: Ie2f2feb07941843f202825061f84cb1bf546f098

fix: resolve use-after-free in RawClientImpl config access (#15)

f1e3f3b

feat: support parsing buffer config from params in AsyncClientConfig (#…

3fe314c

…16)

johnlanni closed this Jan 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: prevent nil pointer dereference in envoyGoFilterOnHttpData#17

fix: prevent nil pointer dereference in envoyGoFilterOnHttpData#17
johnlanni wants to merge 277 commits intomainfrom
fix-nil-pointer-in-onhttpdata

johnlanni commented Jan 31, 2026

Uh oh!

lingma-agents bot commented Jan 31, 2026

Uh oh!

johnlanni commented Jan 31, 2026

Uh oh!

lingma-agents bot commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

johnlanni commented Jan 31, 2026

Description

Problem

Solution

Testing

Uh oh!

lingma-agents bot commented Jan 31, 2026

Uh oh!

johnlanni commented Jan 31, 2026

Uh oh!

lingma-agents bot commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants