feat: support parsing buffer config from params in AsyncClientConfig#16
Merged
johnlanni merged 1 commit intohigress-group:envoy-1.27from Nov 13, 2025
Merged
Conversation
Change-Id: Id2e57fb2599b27c7d6f79e58031c44d8ad4a0b12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable AsyncClientConfig to parse buffer_flush_timeout and
max_buffer_size_before_flush from the params map passed during
construction. This allows WASM plugins to configure Redis client
buffer behavior via URL query parameters.
Changes:
Usage example:
redisInit("cluster?buffer_flush_timeout=1&max_buffer_size_before_flush=512", ...)
This enables runtime configuration of Redis batching behavior for
latency-sensitive or throughput-optimized scenarios without code changes.
Co-developed-by: Claude noreply@anthropic.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Note
Allow
AsyncClientConfigto readbuffer_flush_timeoutandmax_buffer_size_before_flushfrom params, and add tests and WASM plugin usage to validate parsing.paramsinRedis::AsyncClientConfig(buffer_flush_timeout,max_buffer_size_before_flush) with defaults viaparseUint32FromParamshelper inenvoy/redis/async_client.h.<limits>; make related members initialized from parsed values.test_data/test_redis_call_cpp.cc):redisInit/redisCallURLs to set buffer behavior.test/extensions/filters/http/wasm/wasm_filter_test.cc):envoy/redis/async_client.h.RedisAsyncClientConfigTestto cover parsing (defaults, invalid, zero, large, overflow).Written by Cursor Bugbot for commit 6ca8808. This will update automatically on new commits. Configure here.