-
Notifications
You must be signed in to change notification settings - Fork 121
feat(chart): simplify update logic and deprecate some flags #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…s and simplifying chart creation logic
…ing chart instance
… better loading sequence
… storing chart instance
… redraw functionality
|
@karolkolodziej Thanks in advance for the review! 😉 |
|
fix : #428 |
|
We always assumed the wrapper would handle updates based on the input, and now that responsibility shifts to the implementer. |
|
I really appreciate the work here — this PR is top-notch and everything functions as expected. That said, this wrapper has a broad user base that relies heavily on the existing input bindings. Deprecating them entirely feels like a big breaking change with a large impact. Because of that, I’m concerned this change may be too aggressive at this stage. |
|
@karolkolodziej I completely agree with your assessment. Pushing this change as v5.3.0 is too aggressive given the user base reliance on the existing bindings. Proposed Action Plan:
Does this roadmap sound safer to you? If you agree, I can handle the revert and update this PR accordingly. |
|
All sounds excellent. I agree 100% with the approach. |
Summary
This Pull Request introduces significant improvements to the Highcharts wrapper API, focusing on simplifying the chart update logic and giving developers granular control over the rendering lifecycle.
By moving away from "black-box" input bindings, we are streamlining API usage and exposing the native Highcharts instance directly. This allows for more performant and predictable chart updates
Key Changes
The following inputs are now deprecated and will be removed in a future release. Please migrate to the new chartInstance approach described below.
[(update)]and[(oneToOne)]💻 Usage Example
Instead of relying on two-way binding to trigger updates, developers should now capture the chart instance and call the
.update()method manually (e.g., on a button click or signal effect).HTML Template: