This repository was archived by the owner on May 29, 2018. It is now read-only.
Honor chart.options.exporting.fallbackToExportServer flag.#129
Open
tdibacco wants to merge 2 commits intohighcharts:masterfrom
tdibacco:fallbackToExportServer
Open
Honor chart.options.exporting.fallbackToExportServer flag.#129tdibacco wants to merge 2 commits intohighcharts:masterfrom tdibacco:fallbackToExportServer
tdibacco wants to merge 2 commits intohighcharts:masterfrom
tdibacco:fallbackToExportServer
Conversation
TorsteinHonsi
suggested changes
Apr 20, 2017
Contributor
TorsteinHonsi
left a comment
TorsteinHonsi
left a comment
There was a problem hiding this comment.
The fallbackToExportServer option is undefined by default. You should probably do a strict test in case it is not set:
if (chart.options.exporting.fallbackToExportServer !== false)
…o strict test in case it is not set.
Author
|
TorsteinHonsi, Thanks for the review. I updated the PR with the strict check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to honor chart.options.exporting.fallbackToExportServer flag.
Reference
http://api.highcharts.com/highcharts/exporting.fallbackToExportServer