Skip to content

added option to continue dragging when mouse leaves chart area #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorceban wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added option to continue dragging when mouse leaves chart area #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Online demos:
| `plotOptions.series.data.draggableY` | Boolean | If dragging is enabled on the series, set this to false to prevent dragging on a single point. |
| `plotOptions.series.draggableX` | Boolean | Enable draggable along the X axis. |
| `plotOptions.series.draggableY` | Boolean | Enable draggable along the Y axis. |
| `plotOptions.series.allowDragOutsideChartArea` | Boolean | Dragging will contine outside chart area. Defaults to false which automatically triggers a drop on mouseleave. |
| `plotOptions.series.dragHandlePath` | Function | Column series only. A custom path for the drag handle. |
| `plotOptions.series.dragHandleFill` | Function | Column series only. Fill color for the drag handle. |
| `plotOptions.series.dragHandleStroke` | Function | Column series only. Stroke color for the drag handle. |
Expand Down
10 changes: 8 additions & 2 deletions draggable-points.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Draggable points plugin for Highcharts JS
* Author: Torstein Honsi
* License: MIT License
* Version: 2.0.4 (2016-05-23)
* Version: 2.0.6 (2017-02-03)
*/

/*global document, Highcharts */
Expand Down Expand Up @@ -232,6 +232,12 @@
}
}

function conditionalDrop(e) {
if (dragPoint && dragPoint.series.options.allowDragOutsideChartArea) {
return;
}
drop(e);
}
// Kill animation on first drag when chart.animation is set to false.
chart.redraw();

Expand All @@ -242,7 +248,7 @@
addEvent(container, 'touchstart', mouseDown);
addEvent(document, 'mouseup', drop);
addEvent(document, 'touchend', drop);
addEvent(container, 'mouseleave', drop);
addEvent(container, 'mouseleave', conditionalDrop)
});

/**
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Draggable Points",
"version": "2.0.4",
"version": "2.0.6",
"title": "Highcharts Draggable Points",
"demo": [
"[Combined series](http://jsfiddle.net/highcharts/AyUbx/)",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "highcharts-draggable-points",
"version": "2.0.4",
"version": "2.0.6",
"description": "Highcharts plugin that allows points to be dragged and dropped by mouse or touch.",
"main": "draggable-points.js",
"repository": {
Expand Down