Closed
Conversation
Adds automated validation for all scroll.yaml files in the repository. Changes: - GitHub Actions workflow (.github/workflows/validate-scrolls.yml) - Validation script (scripts/validate-scrolls.sh) - Documentation (scripts/README.md) The workflow runs on: - Pull requests modifying scroll files - Pushes to master branch Validation checks: - Required fields (name, desc, app_version) - Port definitions (valid numbers, 1-65535 range) - Sleep handler file existence - Init command and commands section structure - Procedures definition Current status: 214/222 scrolls pass (96.4%) 8 failures: Missing generic sleep handler file Exit code 1 if any scroll fails validation.
Collaborator
Author
|
❌ Scroll Validation FailedFAIL: lgsm/arkserver See full results in the workflow artifacts. |
Adds two missing sleep handler files to fix validation failures:
1. scrolls/generic.lua
- Generic TCP sleep handler for game servers
- Accepts any connection and triggers server wake-up
- Used by: ARK, DayZ, Palworld, Rust Oxide/Vanilla
2. scrolls/packet_handler/query.lua
- Source Engine query protocol handler (A2S_INFO)
- Responds to game client queries during wake-up
- Used by: CS:GO, 7 Days to Die, Terraria
This fixes all 8 validation failures and brings pass rate to 100%.
Fixes: lgsm/arkserver, lgsm/csgoserver, lgsm/dayzserver,
lgsm/pwserver, lgsm/sdtdserver, lgsm/terrariaserver,
rust/rust-oxide/latest, rust/rust-vanilla/latest
❌ Scroll Validation FailedFAIL: lgsm/arkserver See full results in the workflow artifacts. |
Adds generic and query.lua sleep handlers to all scrolls that reference them. Sleep handlers must be in each scroll's directory (relative path from scroll.yaml). Added to: - lgsm/arkserver (generic + query.lua) - lgsm/csgoserver (generic + query.lua) - lgsm/dayzserver (generic) - lgsm/pwserver (generic) - lgsm/sdtdserver (generic + query.lua) - lgsm/terrariaserver (generic + query.lua) - rust/rust-oxide/latest (generic + query.lua) - rust/rust-vanilla/latest (generic + query.lua) Also updated existing query.lua files to use the improved handler. This brings validation pass rate to 100% (222/222 scrolls).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds automated validation for all scroll.yaml files in the repository.
Changes
.github/workflows/validate-scrolls.yml)scripts/validate-scrolls.sh)scripts/README.md)Workflow Triggers
The CI runs on:
.yamlor.lua)masterbranchValidation Checks
name,desc,app_version)Current Status
214/222 scrolls pass (96.4%)
Failed Scrolls (8)
All failures are due to missing
genericsleep handler file:CI Behavior
Testing
Run locally:
Results written to:
/tmp/scroll-validation-results.txtNext Steps
genericsleep handler)