Skip to content

Conversation

@hideakitai
Copy link
Owner

@hideakitai hideakitai commented Oct 7, 2025

@hideakitai hideakitai requested a review from Copilot October 7, 2025 16:14
@hideakitai hideakitai self-assigned this Oct 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables multiple interfaces to be used in one sketch by refactoring the Artnet library to use interface-specific class names and removing the generic Artnet.h header that prevented multiple interfaces.

  • Removes generic Artnet.h header that caused conflicts when using multiple interfaces
  • Updates all interface-specific headers to use prefixed class names (e.g., ArtnetWiFi, ArtnetEther)
  • Updates all example files to use the new interface-specific class names

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Artnet.h Completely removed to eliminate interface conflicts
ArtnetWiFi.h No changes shown in diff
ArtnetEther.h Updated class names from generic to ArtnetEther prefix
ArtnetEtherENC.h Updated class names from generic to ArtnetEtherENC prefix
ArtnetETH.h Updated class names from generic to ArtnetETH prefix
ArtnetNativeEther.h Updated class names from generic to ArtnetNativeEther prefix
examples/WiFi/* Removed outdated comments and updated documentation
examples/Ethernet/* Removed outdated comments and updated class names to ArtnetEther variants
examples/EthernetENC/* Updated class names to ArtnetEtherENC variants
examples/ETH/* Updated class names to ArtnetETH variants
README.md Updated documentation to reflect new API and interface-specific usage
Artnet/Receiver.h Changed flush() to clear() method call

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hideakitai hideakitai force-pushed the feature/enable-multiple-interfaces-in-one-sketch branch from ed7c485 to 03e9506 Compare October 7, 2025 16:18
@hideakitai hideakitai marked this pull request as draft October 7, 2025 21:07
@hideakitai hideakitai force-pushed the feature/enable-multiple-interfaces-in-one-sketch branch 3 times, most recently from 17a0449 to 03e9506 Compare October 16, 2025 17:52
@hideakitai hideakitai marked this pull request as ready for review October 16, 2025 17:56
@hideakitai hideakitai merged commit 281eae7 into main Oct 16, 2025
48 checks passed
@hideakitai hideakitai deleted the feature/enable-multiple-interfaces-in-one-sketch branch October 16, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants