feat: support RDM #135
Draft
feat: support RDM #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
There was a problem hiding this comment.
Pull Request Overview
Adds experimental support for RDM (Remote Device Management) over Art-Net, including new APIs, example sketches, and documentation.
- Introduced RDM/TOD send/receive APIs in
Sender.handReceiver.h - Added WiFi and Ethernet example sketches for RDM device and controller
- Extended README with RDM section and updated API reference
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/WiFi/rdm_example/rdm_example.ino | New WiFi RDM device example demonstrating subscribe/send flows |
| examples/WiFi/rdm_controller/rdm_controller.ino | New WiFi RDM controller example for discovery and device commands |
| examples/Ethernet/rdm_example/rdm_example.ino | New Ethernet RDM device example |
| README.md | Added RDM section, examples, and send/subscribe API documentation |
| Artnet/Sender.h | Added sendArtRdm*, sendArtTod* methods |
| Artnet/Receiver.h | Added subscribeArtRdm*, unsubscribeArtRdm*, and OpCode handling |
| Artnet/ArtRdm.h | Introduced RDM, RDMSub, TOD request/data/control packet formats |
Comments suppressed due to low confidence (2)
Artnet/ArtRdm.h:199
- [nitpick] The field name
add_countis ambiguous; renaming it toaddress_countoraddr_countwould improve clarity for consumers of this metadata.
uint8_t add_count;
Artnet/ArtRdm.h:46
- [nitpick] Consider adding unit tests for RDM metadata parsing and packet serialization functions (
generateMetadataFromOpRdm,setMetadataToOpRdm, etc.) to verify correct behavior and prevent regressions.
inline Metadata generateMetadataFromOpRdm(const uint8_t* packet) {
| case OpCode::TodRequest: { | ||
| if (this->callback_art_tod_request) { | ||
| art_tod_request::Metadata metadata = art_tod_request::generateMetadataFromOpTodRequest(this->packet.data()); | ||
| this->callback_art_tod_request((uint16_t*)(this->packet.data() + art_tod_request::ADDRESS), metadata.add_count, metadata, remote_info); |
There was a problem hiding this comment.
Casting raw packet bytes to uint16_t* may cause unaligned memory access on some platforms; consider manually parsing each 16-bit address into a local uint16_t array before invoking the callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #125
Experimental support for RDM