Fix code to allow configurable application logo#13
Open
BlairCooper wants to merge 4 commits intohicsail:masterfrom
Open
Fix code to allow configurable application logo#13BlairCooper wants to merge 4 commits intohicsail:masterfrom
BlairCooper wants to merge 4 commits intohicsail:masterfrom
Conversation
- Added .vscode to .gitignore - Made application icon and logo configurable through setup.js. Use Config.getAppIcon() and Config.getAppLogo() methods to access. - Cleaned up handling of /contact request to remove duplicate code. - Made map on Contact page configurable through contact_info.json
| @@ -1,6 +1,10 @@ | |||
| { | |||
| "omit" : "ommiting any of the field below will disable them from being displayed on the Contact page", | |||
| "direct_phone": "XXX-XXX-XXXX", | |||
Contributor
There was a problem hiding this comment.
Did you intend this to be an extra field? Seems like a comment @BlairCooper
Contributor
Author
There was a problem hiding this comment.
It is a comment but there isn't any other way to comment a JSON file.
- Added .vscode to .gitignore - Made application icon and logo configurable through setup.js. Use Config.getAppIcon() and Config.getAppLogo() methods to access. - Cleaned up handling of /contact request to remove duplicate code. - Made map on Contact page configurable through contact_info.json
…at-pro into getProfileLogo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Config.getAppIcon() and Config.getAppLogo() methods to access.