Refactor bloom filter to support async file I/O operations#617
Merged
Conversation
This commit converts the bloom filter implementation from synchronous to asynchronous to support non-blocking file I/O, enabling better performance in concurrent environments. Key changes: - Made BloomFilter trait async using #[async_trait::async_trait] - Updated is_bit_set to return Result<bool> and be async - Converted check_bits and may_contain methods to async - Replaced direct memory mapping in ImmutableBloomFilter with FileIO trait for async file operations - Updated all implementations (BlockedBloomFilter, ImmutableBloomFilter) - Converted tests from #[test] to #[tokio::test] - Added proper error handling throughout with anyhow::Result Files modified: - rs/utils/src/bloom_filter/mod.rs: Made trait async - rs/utils/src/bloom_filter/blocked_bloom_filter.rs: Updated implementation - rs/utils/src/bloom_filter/immutable_bloom_filter.rs: Uses FileIO instead of Mmap - rs/utils/src/bloom_filter/reader.rs: Updated to async read operations This change enables bloom filters to work efficiently with async runtimes and distributed file systems where blocking operations are not desirable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit converts the bloom filter implementation from synchronous to asynchronous to support non-blocking file I/O, enabling better performance in concurrent environments.
Key changes:
Files modified:
This change enables bloom filters to work efficiently with async runtimes and distributed file systems where blocking operations are not desirable.