fix: toast hidden behind modals due to stacking context#14
Open
ssantss wants to merge 2 commits intohiaaryan:mainfrom
Open
fix: toast hidden behind modals due to stacking context#14ssantss wants to merge 2 commits intohiaaryan:mainfrom
ssantss wants to merge 2 commits intohiaaryan:mainfrom
Conversation
|
Having same issue when integrating with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Toasts render inline in the DOM tree wherever
<Toaster />is placed.When a modal or overlay with a higher z-index is open, toasts appear behind it
because of CSS stacking context limitations — no matter how high the z-index is.
Solution
createPortalfromreact-domto render toast viewports directly intodocument.bodymountedstate) to preventdocument.bodyaccess during server-side rendering (Next.js, Remix, etc.)50to9999(industry standard for notifications)This is the same approach used by sonner, react-hot-toast, and react-toastify.
Files changed
src/toast.tsx— portal + SSR guardsrc/styles.css— z-index 50 → 9999