Open
Conversation
hhadian
approved these changes
Nov 18, 2018
Owner
hhadian
left a comment
hhadian
left a comment
There was a problem hiding this comment.
That was fast, thanks a lot!
I have added a few minor comments just for your info. You can fix them if you want (by pushing more commits) but you don't have to...
| color += HexArr[Math.floor(Math.random() * 16)]; | ||
| } | ||
| return color; | ||
| } No newline at end of file |
Owner
There was a problem hiding this comment.
Always use a newline at the end of source files.
Suggested change
| } | |
| } | |
| @@ -0,0 +1,241 @@ | |||
| html { | |||
| box-sizing: border-box; | |||
Owner
There was a problem hiding this comment.
JFYI, it's better to use spaces instead of tabs (2 spaces instead of each tab). If you are on linux, you could do sed -i "s|\t| |g" main.css to replace all tabs.
Suggested change
| box-sizing: border-box; | |
| box-sizing: border-box; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I developed a web page respected to your needs from a open source web page template.
It has interesting features like it's random background color with a blurry theme.
Enjoy 😄