Collection of improvements #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
particularly it has no name attribute that would be required
otherwise there is a name clash with the name attribute of the nodes before this change the CLI for repeats was ``` if str($i_repeat....) == "when_content" ``` now its ``` if str($i_ACTUAL_REPEAT_NAME....) == "when_content" ```
if the `mako_path` parameter is passed to the `command_line` function then the path is overwritten, i.e. if the repeat is contained in or contains other conditionals, repeats, etc they do not appear in the path of the produced variable.
outer element need to be first
bernt-matthias
force-pushed
the
imp
branch
8 times, most recently
from
284e93c to
69b9bed
Compare
missing deploy so far
and code simplification
but take as given
command needs to be a list
i.e. non-empty
bernt-matthias
commented
Apr 15, 2025
Collaborator
Author
|
@hexylena totally forgot about this one. Guess this is ready for review :) |
Owner
|
Hoi @bernt-matthias sounds good! I'll give it a look |
hexylena
approved these changes
Apr 22, 2025
hexylena
approved these changes
Apr 22, 2025
Collaborator
Author
|
Hey @hexylena thanks fort merging. Can we prepare a new release here? Let me know if I can help. |
Owner
I think if you create a new tag, the rest will be handled. Would you like to? Judging by my commit message the last time I touched the automated release, I did not enjoy the process 😆 but maybe it's fully automated now, or you can tell me what needs to be fixed. |
Collaborator
Author
|
I created 0.5.4 .. but it tries to push 0.5.3 .. which fails :( |
Owner
|
ah was just missing the package bump: 2a26948 thanks for testing it for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just using
galaxyxmlin some project. Will collect bugfixes and improvements here.Will ping when ready.