Skip to content

Conversation

@hextriclosan
Copy link
Owner

No description provided.

@hextriclosan hextriclosan requested a review from Copilot October 31, 2025 22:32
@hextriclosan hextriclosan merged commit ef81d9b into main Oct 31, 2025
5 checks passed
@hextriclosan hextriclosan deleted the java-17 branch October 31, 2025 22:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's Java version from 1.8 to 17 and adds explicit constructors to strategy implementation classes.

  • Updates Maven compiler configuration to target Java 17
  • Adds documented no-arg constructors to FullCompression and PathHalvingCompression classes
  • Reformats JavaDoc parameter alignment for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pom.xml Updates Maven compiler properties from Java 1.8 to Java 17, adding maven.compiler.release property
PathHalvingCompression.java Adds explicit no-arg constructor with JavaDoc and reformats parameter documentation alignment
FullCompression.java Adds explicit no-arg constructor with JavaDoc and reformats parameter documentation alignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +12 to 17
/**
* Creates a new PathHalvingCompression strategy.
*/
public PathHalvingCompression() {
}

Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The explicit empty constructor provides no additional functionality beyond the default constructor. Consider removing it or adding a comment explaining why it's explicitly defined (e.g., for documentation purposes or future extension).

Suggested change
/**
* Creates a new PathHalvingCompression strategy.
*/
public PathHalvingCompression() {
}

Copilot uses AI. Check for mistakes.
Comment on lines +13 to 18
/**
* Creates a new FullCompression strategy.
*/
public FullCompression() {
}

Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The explicit empty constructor provides no additional functionality beyond the default constructor. Consider removing it or adding a comment explaining why it's explicitly defined (e.g., for documentation purposes or future extension).

Suggested change
/**
* Creates a new FullCompression strategy.
*/
public FullCompression() {
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants