-
Notifications
You must be signed in to change notification settings - Fork 0
Use java version 17 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project's Java version from 1.8 to 17 and adds explicit constructors to strategy implementation classes.
- Updates Maven compiler configuration to target Java 17
- Adds documented no-arg constructors to
FullCompressionandPathHalvingCompressionclasses - Reformats JavaDoc parameter alignment for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Updates Maven compiler properties from Java 1.8 to Java 17, adding maven.compiler.release property |
| PathHalvingCompression.java | Adds explicit no-arg constructor with JavaDoc and reformats parameter documentation alignment |
| FullCompression.java | Adds explicit no-arg constructor with JavaDoc and reformats parameter documentation alignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * Creates a new PathHalvingCompression strategy. | ||
| */ | ||
| public PathHalvingCompression() { | ||
| } | ||
|
|
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The explicit empty constructor provides no additional functionality beyond the default constructor. Consider removing it or adding a comment explaining why it's explicitly defined (e.g., for documentation purposes or future extension).
| /** | |
| * Creates a new PathHalvingCompression strategy. | |
| */ | |
| public PathHalvingCompression() { | |
| } |
| /** | ||
| * Creates a new FullCompression strategy. | ||
| */ | ||
| public FullCompression() { | ||
| } | ||
|
|
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The explicit empty constructor provides no additional functionality beyond the default constructor. Consider removing it or adding a comment explaining why it's explicitly defined (e.g., for documentation purposes or future extension).
| /** | |
| * Creates a new FullCompression strategy. | |
| */ | |
| public FullCompression() { | |
| } |
No description provided.