Merged
Conversation
Merge pull request #46 from hexawulf/feat/production-logging-winston
- Updated Winston logger file transport paths in `server/src/logger/index.ts` to use `path.resolve(__dirname, '../../logs')` for more robust path resolution, ensuring logs are correctly written regardless of the application's CWD.
- Deleted the deprecated `server/routes-old.ts` file.
- Completed a comprehensive sweep of all `console.log` and `console.error` (and other console variants) calls within the `server/` directory (excluding `server/vite.ts` which has its own specific logger) and replaced them with appropriate Winston logger methods (e.g., `logger.info`, `logger.error`, `logger.warn`, `logger.debug`). This includes thorough updates in `server/firebaseAuth.ts` and `server/routes.ts`.
- Added a test log message `logger.info('Winston logger initialized – startup check')` to `server/index.ts` to help verify logger initialization.
User has manually tested and confirmed that logs are now appearing as expected in both the console (development mode) and the `logs/combined.log` and `logs/error.log` files.
|
Caution Review failedThe pull request is closed. WalkthroughConsole-based logging across server modules is replaced with structured Winston logger calls, enhancing log detail and security. Log statements now include contextual metadata and avoid exposing sensitive information. The logs directory path resolution is updated for reliability. The legacy route and WebSocket server implementation is removed. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ExpressServer
participant Logger
participant FirebaseAuth
participant WebSocketServer
Client->>ExpressServer: HTTP request
ExpressServer->>Logger: logger.info/debug/warn/error (with metadata)
ExpressServer->>FirebaseAuth: Validate authentication
FirebaseAuth->>Logger: logger.info/debug/warn/error (with metadata)
ExpressServer-->>Client: HTTP response
Client->>WebSocketServer: WebSocket connect/message
WebSocketServer->>Logger: logger.info/debug/warn/error (with client IP)
WebSocketServer-->>Client: Broadcast/response
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit