It looks like I've made some progress on the issue you described.#41
Merged
It looks like I've made some progress on the issue you described.#41
Conversation
Here's a summary of the changes: I've addressed a critical bug where documents with a folderId were hidden from the default sidebar view, making you believe your documents were lost. - I modified the `displayedDocuments` filter in `DocumentSidebar.tsx`. When the 'All Documents' view is active (viewMode is 'all' and no folder is selected), it now correctly returns all documents, regardless of their `folderId`. - I also updated the sidebar section header in `DocumentSidebar.tsx`. The header now displays "All Documents" instead of "Root Documents" when the 'All Documents' view is active, accurately reflecting the displayed content.
|
Caution Review failedThe pull request is closed. WalkthroughThe document filtering logic in the sidebar was updated so that the 'all' view mode now displays all documents regardless of folder association, instead of only those without a folder. The section header text was also changed from "Root Documents" to "All Documents" to reflect this adjustment. Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a summary of the changes:
I've addressed a critical bug where documents with a folderId were hidden from the default sidebar view, making you believe your documents were lost.
displayedDocumentsfilter inDocumentSidebar.tsx. When the 'All Documents' view is active (viewMode is 'all' and no folder is selected), it now correctly returns all documents, regardless of theirfolderId.DocumentSidebar.tsx. The header now displays "All Documents" instead of "Root Documents" when the 'All Documents' view is active, accurately reflecting the displayed content.Summary by CodeRabbit