-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Update dependencies and environment configurations #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates dependencies to their latest versions and refactors the type system to simplify polymorphic component patterns. Key changes include removing the BlockLabel generic parameter from type utilities, migrating ESLint configuration to the new flat config format (.mjs), and improving code quality throughout the codebase.
- Simplified type system by removing the
BlockLabelparameter and explicitly addingLabelPropswhere needed - Updated dependencies including React 19, Storybook 10, and Tailwind 4
- Migrated ESLint configuration from
eslint.config.jstoeslint.config.mjswith improved type-aware rules
Reviewed changes
Copilot reviewed 50 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated all dependencies to latest versions, including major version updates for Storybook (9→10) |
| eslint.config.mjs | New ESLint flat config with enhanced type-checking rules and React best practices |
| eslint.config.js | Removed old ESLint configuration file |
| src/types/polymorphic.ts | Removed BlockLabel generic parameter, simplified type definitions with clearer documentation |
| src/types/common.ts | Removed EssentialProps, extracted LabelProps and TestIdProps as separate interfaces |
| src/types/html-tag.ts | Added ContainerHtmlTag type export |
| src/data/html-tag.ts | Added CONTAINER_HTML_TAGS constant array |
| src/layouts/Box/Box.tsx | Explicitly added LabelProps to component props, updated return type annotation |
| src/layouts/Grid/Grid.tsx | Changed to extend BoxProps, updated return type to React.JSX.Element |
| src/layouts/Flex/Flex.tsx | Changed to extend BoxProps, updated return type to React.JSX.Element |
| src/layouts/Container/Container.tsx | Refactored to use ContainerHtmlTag, improved type safety with Record<> |
| src/layouts/Flex/Flex.stories.tsx | Updated Tailwind classes to use newer syntax (e.g., shrink-0 vs flex-shrink-0) |
| src/layouts/Box/Box.stories.tsx | Updated spacing utility classes to numeric format |
| src/components/*/**.tsx | Added explicit LabelProps, updated return types to React.JSX.Element, improved type annotations |
| src/components/*/**.test.tsx | Improved test assertions using Testing Library matchers, removed unnecessary type casts and async markers |
| src/utils/is-local-url.ts | Changed type to interface for IsLocalOptions |
| src/utils/cn.ts | Added explicit return type annotation |
| vite.config.ts | Added src/main.tsx and src/App.tsx to coverage exclusions |
| src/App.tsx | Changed empty fragment to render <main /> element, added return type |
| src/tests/main.test.tsx | Removed test file for development-only entry point |
| src/tests/App.test.tsx | Removed test file for development-only component |
| src/tests/index.test.ts | Removed unnecessary async markers from tests |
| src/tests/client.test.ts | Removed unnecessary async markers from tests |
| .storybook/main.ts | Simplified regex test to use .includes(), removed unnecessary async from callback |
…rokwon/framix into chore/update-deps-and-configs
🔍 Overview
🛠 Changes
ESLintfrom legacy config to flat config format (eslint.config.mjs) with TypeScript-aware rules and improvedReact/StorybooksupportReact.JSX.Elementreturn types and TypeScript improvements across components.toBeChecked/toHaveValue)Tailwindclass optimizationspnpm-lock.yamlandpackage.jsonpeerDependencies for compatibility❗ Related Issues