Add warning when deploying with end-of-life Node.js versions#1578
Open
colincasey wants to merge 3 commits intomainfrom
Open
Add warning when deploying with end-of-life Node.js versions#1578colincasey wants to merge 3 commits intomainfrom
colincasey wants to merge 3 commits intomainfrom
Conversation
Display a warning during build when the resolved Node.js version has reached end-of-life, informing users of the EOL date, currently supported versions, and a link to the support documentation. Includes a configurable error (disabled by default) controlled by the IGNORE_EOL_ERROR_NODEJS config var that can be enabled in the future to block builds using EOL versions. Fixes W-21451598
When resolving from the inventory, the version is known before downloading so the EOL check can fail fast without wasting time on the download. When using NODE_BINARY_URL, the version isn't known until after install so the check remains post-install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IGNORE_EOL_ERROR_NODEJSconfig var that can be enabled in the future to block builds using EOL versionsTest plan
testEolVersionWarningverifies EOL warning appears in build outputFixes W-21451598