Skip to content

Fix failing tests#218

Merged
edmorley merged 1 commit intomainfrom
schneems/fix-tests-2025-04-08
Apr 8, 2025
Merged

Fix failing tests#218
edmorley merged 1 commit intomainfrom
schneems/fix-tests-2025-04-08

Conversation

@schneems
Copy link
Copy Markdown
Contributor

@schneems schneems commented Apr 8, 2025

Tests are failing with this output:


       expected "-----> Building on the Heroku-24 stack\n-----> Fetching https://github.com/heroku/heroku-buildpack-r...: rake test\n505b817aba132559e51bfc599fe8a1c7\n-----> Ruby buildpack tests completed successfully\n" to match "Using rake"
       Diff:
       @@ -1 +1,89 @@
       -Using rake
       +-----> Building on the Heroku-24 stack
       +-----> Fetching https://github.com/heroku/heroku-buildpack-ruby.git#main buildpack...
       +       buildpack downloaded
       +-----> Ruby app detected
       +-----> Installing bundler 2.3.25
       +-----> Removing BUNDLED WITH version in the Gemfile.lock
       +-----> Setting up Test for Ruby/Rack
...
       +-----> Installing dependencies using bundler 2.3.25
       +       Running: BUNDLE_WITHOUT='development' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       +       Bundle complete! 2 Gemfile dependencies, 3 gems now installed.
       +       Gems in the group 'development' were not installed.
       +       Bundled gems are installed into `./vendor/bundle`
       +       Bundle completed (0.45s)
       +       Cleaning up the bundler cache.

Bundler changed their output. They no longer emit gems that are already installed. I changed the default bundler version used when none is specified from bundler 1.x to 2.3.x so that's why this is failing now.

We are asserting that "Installing rake" is seen in the first build and not in the second build already. The goal was to show that caching is working. This line is not needed.

Tests are failing with this output:

```

       expected "-----> Building on the Heroku-24 stack\n-----> Fetching https://github.com/heroku/heroku-buildpack-r...: rake test\n505b817aba132559e51bfc599fe8a1c7\n-----> Ruby buildpack tests completed successfully\n" to match "Using rake"
       Diff:
       @@ -1 +1,89 @@
       -Using rake
       +-----> Building on the Heroku-24 stack
       +-----> Fetching https://github.com/heroku/heroku-buildpack-ruby.git#main buildpack...
       +       buildpack downloaded
       +-----> Ruby app detected
       +-----> Installing bundler 2.3.25
       +-----> Removing BUNDLED WITH version in the Gemfile.lock
       +-----> Setting up Test for Ruby/Rack
...
       +-----> Installing dependencies using bundler 2.3.25
       +       Running: BUNDLE_WITHOUT='development' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       +       Bundle complete! 2 Gemfile dependencies, 3 gems now installed.
       +       Gems in the group 'development' were not installed.
       +       Bundled gems are installed into `./vendor/bundle`
       +       Bundle completed (0.45s)
       +       Cleaning up the bundler cache.
```

Bundler changed their output. They no longer emit gems that are already installed. I changed the default bundler version used when none is specified from bundler 1.x to 2.3.x so that's why this is failing now.

We are asserting that "Installing rake" is seen in the first build and not in the second build already. The goal was to show that caching is working. This line is not needed.
@schneems schneems requested a review from a team as a code owner April 8, 2025 20:32
Copy link
Copy Markdown
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@edmorley edmorley merged commit 9e6a8be into main Apr 8, 2025
6 of 7 checks passed
@edmorley edmorley deleted the schneems/fix-tests-2025-04-08 branch April 8, 2025 20:50
@edmorley edmorley mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants