Conversation
bin/util
Outdated
| Darwin) sed -l "$c";; | ||
| *) sed -u "$c";; | ||
| esac | ||
| } No newline at end of file |
`No newline at end of file`
from `config vars`
README.md
Outdated
| The buildpack will detect your app as ASP.NET 5 if it has `project.json`. If the source code you want to build contains multiple `project.json` files, you can use a [`.deployment`](https://github.com/projectkudu/kudu/wiki/Customizing-deployments) or set a `$PROJECT` config var to control which one is built. | ||
| The buildpack will detect your app as ASP.NET Core if it has `project.json`. If the source code you want to build contains multiple `project.json` files, you can use a [`.deployment`](https://github.com/projectkudu/kudu/wiki/Customizing-deployments) or set a `$PROJECT` config var to control which one is built. | ||
|
|
||
| ## Attension |
There was a problem hiding this comment.
I'm poor in English.
I think sentences in Attention should be more properly, but I don't know how to write.
bin/compile
Outdated
| echo "${PROJECT_NAME:=$PROJECT_DIR_NAME}" | ||
|
|
||
| echo "Restoring the packages" | ||
| dotnet restore ${PROJECT_JSON_FILE} |
There was a problem hiding this comment.
If the repository contains multiple projects this line won't restore all dependencies causing a runtime error. Instead should be dotnet restore ${SRC_DIR} or if the structure of repo contains src and tests folders (which usually it does), better yet dotnet restore ${SRC_DIR}/src
There was a problem hiding this comment.
@jenyayel
Yes I have known it before. But I think it's a bug(or feature?) of dotnet restore that it doesn't restore the reference-local project automatically.
If it restore projects at root path, I'm afraid that it may take too much time and size during restoring if sb. contains several unused project.
There was a problem hiding this comment.
@noliar, I think it is a feature. Like before running (or packing in this case) your app (not just in .net), you need explicitly restore all packages.
It seems to me that in most of the cases when you deploy the repo, you aiming to restore everything (except for tests).
dotnet/cli#4065
|
May I also suggest to add support for |
|
Merge it, merge this for the glory 👍 |
|
Probably won't happen. Two main contributors of this repo no longer work at Heroku. I contacted support of Heroku, they told that this repo is experimental and they way to go with .NET Core is to use Dockerfile. |
|
Thank you for the answer @jenyayel |
|
Well, it's a new candy that every one tries to push. I wrote a short guideline that may be helpful. Good luck! |
|
I updated my fork and sent a PR: #10 You can try my version here: https://github.com/friism/dotnet-buildpack I just did this as an experiment to to see where the .NET Core toolchain was at. As @jenyayel mentioned, the Docker approach works really well too. I built a full .NET Core Postgres example here: https://github.com/friism/heroku-docker-dotnet-core-postgres |
5 participants
A simple demo: https://github.com/noliar/ASP.NET-Core-Sample.
The Preview URL: https://netcore.herokuapp.com/