Add relative file resolver base path to mapping launcher. #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I struggled a bit to figure out how to write a test here so this might need revising. Another feature I want to add is a Java-compatible builder for the |
mikesname
force-pushed
the
feature/add_relative_base_path
branch
from
cad3eeb to
fdb6961
Compare
Typically (the default) ShExML relative file sources are resolved for loading, uh, relative to the CWD. This can be tricky in some environments where you can't necessarily know this when writing the mapping rules. This change allows explicitly providing the base path from which relative files are loaded.
mikesname
force-pushed
the
feature/add_relative_base_path
branch
from
fdb6961 to
8fb58c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically (the default) ShExML relative file sources are resolved for loading, uh, relative to the CWD. This can be tricky in some environments where you can't necessarily know this when writing the mapping rules. This change allows explicitly providing the base path from which relative sources are loaded.