Kotlin: hide elements that not need to be visible#1792
Merged
pwrobeldev merged 9 commits intomasterfrom Jan 22, 2026
Merged
Conversation
To ensure the same level of API documentation that Java provides the comment in 'KotlinNativeBase' should use '/**' to be recognized by Dokka engine. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
The comment uses '/**' to be recognized by Dokka engine. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
These functions do not need to be public. They should not be directly accessed by the users of the types -- instead, the users should use the usual constructors. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
These functions should not be accessed by the users. They are just the implementation details. The users should access the usual constructors. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
In Gluecodium we can specify 'external' types for Kotlin. When such type is specified, then in all APIs we use it, but in JNI layer we convert it to our internal representation. Such internal representation is later converted to and from C++. The class which is the 'internal representation' should not be public -- it is just the implementation detail. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
The internal representation should not be public. Therefore, such types are annotated as internal. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
The converter classes are also an implementation detail. They are accessed from JNI layer. The user should not access them. In Java they are package-private. Therefore, in Kotlin we make them 'internal'. Because 'internal representation type' generated for external type is internal, the methods, which use it must also be internal. Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Hsilgos
approved these changes
Jan 21, 2026
pwrobeldev
deleted the
pwrobeldev/hide-kotlin-elements-that-not-need-to-be-visible
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit hides the element generated for Kotlin code, which do not need to
be visible for the end users. The introduced changes are as follows:
Moreover, this commit improves the documentation of
KotlinNativeBase.KDoc syntax is used to properly render the comments.