Fix zoom glitch and add smart zoom for margin cropping#6
Draft
Fix zoom glitch and add smart zoom for margin cropping#6
Conversation
- Track actual PDFView scale factor via viewScaleFactor property - Use actual view scale as base when zooming from fitToWidth mode - Add smartZoom command that toggles between fitToWidth and margin crop - Add 'w' keybinding and ':smartzoom'/':sz' command mode aliases - Update help panel and README documentation Co-authored-by: herbertwxin <28001854+herbertwxin@users.noreply.github.com>
Co-authored-by: herbertwxin <28001854+herbertwxin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix zoom functionality for better usability
Fix zoom glitch and add smart zoom for margin cropping
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoom in/out from fit-to-width mode used the stale
zoomScale(default 1.0) as base instead of the actual PDFView scale factor, causing erratic jumps. Smart zoom added to maximize screen utilization.Root cause
When
fitToWidth = true, PDFKit'sautoScalesmanages the scale factor independently (e.g. 0.7×). Pressing+computed1.0 * 1.25 = 1.25instead of0.7 * 1.25 = 0.875, producing a jarring jump.Changes
LectorPDFViewnow observesPDFViewScaleChangedand writes the actualscaleFactorback toAppState.viewScaleFactorzoomIn/zoomOutuseviewScaleFactoras base when transitioning from fit-to-width,zoomScaleotherwisewkey,:smartzoom): Toggles between fit-to-width and a tighter zoom that eliminates margin whitespace by comparing the page's cropBox to its mediaBox and scaling by the width ratio💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.