Installer is now able to discover tests#49
Open
sq6jnx wants to merge 6 commits intohepabolu:masterfrom
Open
Conversation
added 6 commits
October 26, 2019 22:14
Tests do not take 40 seconds on my 10yo laptop
Removed ambiguity on test file names
sq6jnx
changed the title
Contributor
Author
|
Ready for merge except one fixup commit and question posted in PR description. Please take a look at this. |
Contributor
Author
|
Any news on this? |
hepabolu
approved these changes
Aug 13, 2020
hepabolu
approved these changes
Aug 13, 2020
hepabolu
approved these changes
Aug 13, 2020
hepabolu
approved these changes
Aug 13, 2020
hepabolu
approved these changes
Aug 13, 2020
hepabolu
approved these changes
Aug 13, 2020
Owner
|
Sorry for taking such a long time to respond. Re the naming: I'm fine with |
Owner
|
If you can fix the conflict, then please go ahead and merge the pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding tests for #48 I encountered difficulty on adding test file for it. Hence, I decided to add test discoverability for installer.
I'm not sure however how should I rename test files:
tests/eq.my→tests/test-mytap-eq.mytests/test-mytap-event.my→tests/event.my