feat: support loading 3D AMReX particle

[henry2004y]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @henry2004y, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flekspy library by introducing full support for loading 3D AMReX particle datasets. The changes involve updating the internal header parsing mechanism to correctly interpret three-dimensional domain information. To ensure the reliability and correctness of this new feature, a comprehensive testing setup has been added, including a utility to generate mock 3D AMReX data and a dedicated test suite to validate the loading process.

Highlights

• 3D AMReX Particle Data Support: The core functionality of loading 3D AMReX particle datasets has been implemented by adjusting the header parsing logic to correctly interpret 3D domain dimensions.
• Robust 3D Data Parsing: The _parse_main_header method in particle_data.py now explicitly handles 3D dimension extraction, ensuring accurate x1, y1, z1, x2, y2, z2 coordinate assignments from the header file.
• Mock 3D Data Fixture: A new pytest fixture, mock_3d_amrex_data, has been added to conftest.py. This fixture generates a complete mock 3D AMReX particle dataset directory structure, including main and particle headers, and binary particle data, facilitating reliable testing.
• Dedicated 3D Loading Test: A new test file, test_3d_loading.py, has been introduced. It contains a test case that utilizes the mock 3D data fixture to verify the correct loading, dimension detection, and data shape of 3D AMReX particle datasets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for loading 3D AMReX particle data. The changes include updating the header parsing logic to handle 3D domain definitions, adding a pytest fixture to generate mock 3D data, and a new test to verify the loading process. The implementation is correct and well-tested. I've provided a few suggestions to improve code quality and readability by removing unused code and refactoring a complex part of the parsing logic for better clarity.

[codecov]

Codecov Report

❌ Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.23%. Comparing base (5aa7655) to head (bb730c3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/flekspy/amrex/particle_data.py	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   78.79%   79.23%   +0.43%     
==========================================
  Files          32       33       +1     
  Lines        4391     4464      +73     
==========================================
+ Hits         3460     3537      +77     
+ Misses        931      927       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.