-
Notifications
You must be signed in to change notification settings - Fork 1
Rename AMReXParticleData to AMReXParticle #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AMReXParticleData to AMReXParticle #180
Conversation
This change renames the `AMReXParticleData` class to `AMReXParticle` in `src/flekspy/amrex/particle_data.py` and updates all references across the codebase, including tests, documentation, and samples. This rename aims for conciseness and better alignment with other class names in the library. Breaking Changes: - `AMReXParticleData` is now `AMReXParticle`. Users should update their code to use the new class name.
Summary of ChangesHello @henry2004y, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to rename the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 31 31
Lines 4341 4341
=======================================
Hits 3401 3401
Misses 940 940 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily renames the AMReXParticleData class to AMReXParticle across the entire codebase. This change is reflected in imports, class definitions, docstrings, code examples in docs/amrex_data.ipynb, sample scripts like samples/vdf_matrix.py, and all relevant test files (tests/test_amrex_3d_plots.py, tests/test_amrex_loader.py, tests/test_fleks.py, tests/test_gmm_parameters.py). The flekspy/__init__.py file was also updated to correctly export and load the newly named class. There were no review comments provided for these changes.
This change renames the
AMReXParticleDataclass toAMReXParticleinsrc/flekspy/amrex/particle_data.pyand updates all references across the codebase, including tests, documentation, and samples. This rename aims for conciseness and better alignment with other class names in the library.Breaking Changes:
AMReXParticleDatais nowAMReXParticle. Users should update their code to use the new class name.