Skip to content

Conversation

@henry2004y
Copy link
Owner

Manually provide v_th=0.0001 in the extract_core_population demo
within docs/amrex_data.ipynb to illustrate how to override automatic
estimation.

Manually provide `v_th=0.0001` in the `extract_core_population` demo
within `docs/amrex_data.ipynb` to illustrate how to override automatic
estimation.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @henry2004y, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation by updating a demo in the amrex_data.ipynb notebook. The primary goal is to provide a clearer example of how to manually specify the thermal velocity (v_th) when using the extract_core_population function, thereby demonstrating the override capability for this parameter.

Highlights

  • Documentation Update: The extract_core_population demo within docs/amrex_data.ipynb has been updated.
  • Manual Thermal Velocity: The demo now explicitly provides v_th=0.0001 to illustrate how to manually override the automatic estimation of thermal velocity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the core extraction demo in the amrex_data.ipynb notebook to show how to manually provide a thermal velocity. The change is correct and achieves the stated goal. I've added one suggestion to improve the readability of the code example and to clarify the new parameter.

"# Extract core population using 3D velocity\n",
"core_mask, supra_mask = pd.extract_core_population(\n",
" [\"velocity_x\", \"velocity_y\", \"velocity_z\"], v_dim=3, cutoff=3.0\n",
" [\"velocity_x\", \"velocity_y\", \"velocity_z\"], v_dim=3, v_th=0.0001, cutoff=3.0\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line has become quite long with the new parameter. For better readability and to make the demonstration clearer, consider breaking the arguments onto separate lines. This also provides a good place to add a comment explaining the purpose of the manually provided v_th value, which is currently a "magic number".

Suggested change
" [\"velocity_x\", \"velocity_y\", \"velocity_z\"], v_dim=3, v_th=0.0001, cutoff=3.0\n",
" [\"velocity_x\", \"velocity_y\", \"velocity_z\"],\n",
" v_dim=3,\n",
" v_th=0.0001, # Manually specify thermal velocity\n",
" cutoff=3.0\n",

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.34%. Comparing base (af12a39) to head (37f0b29).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files          31       31           
  Lines        4341     4341           
=======================================
  Hits         3401     3401           
  Misses        940      940           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henry2004y henry2004y merged commit 98765e2 into main Jan 1, 2026
3 checks passed
@henry2004y henry2004y deleted the docs-manual-vth-demo-4734446353231635042 branch January 1, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant