pdfcpu 0.6.0 #12
Open
pdfcpu 0.6.0 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heusel <christian@heusel.eu>
Closed
|
Thanks @christian-heusel for the PR. Sure, I can help with it, but it will take some time as I've never worked with "go" before. |
Contributor
Author
|
This is not so much about the code review but rather about building the resulting application (see i.e. the dockerfile in this repo) and feeding it some PDFs and checking that the output pdfs look good and that there are no errors (for example in the browser console) during the pdf processing. Once the basic testing is done you could update the version in the MaMpf repo 👍🏻 |
|
Note I did not forget about this, but have been been busy last weekend. As we have Christmas vacation soon, I will try to do it during that time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds PR #11 😊
This PR will need some extensive testing, maybe that is something you can help with @Splines?