Improvements to command line interface#16
Open
merlinz01 wants to merge 4 commits intohenadzit:mainfrom
Open
Conversation
henadzit
requested changes
Apr 25, 2025
Owner
henadzit
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Although I don't like the idea of adding dependencies to the project when it can be avoided. There is no need to have click, this can be achieved with argparse.
Contributor
Author
|
IMHO it's worth the single dependency for the increase in readability/maintainability, type safety, functionality, and user experience quality. Aerich uses |
Contributor
Author
|
OK, I've gotten it fairly similar without click dependency, with a few helper functions. See the updated code. |
bb124c9 to
e7132c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
clickinstead ofargparsefor the command line interface.Benefits include:
Aborterror to exit cleanly