Open
Conversation
src/lib/Hub.ts
Outdated
| console.log(error); | ||
| return { | ||
| ok: false, | ||
| body: Buffer.from({errorCode: error}), |
There was a problem hiding this comment.
Buffer.from 파라미터는 string이 들어가야 합니다.
body: Buffer.from(JSON.stringify({errorCode: error})),
src/lib/Hub.ts
Outdated
| public async handleRequest(request: Buffer): Promise<Response> { | ||
| let verifiedRequest; | ||
| try { | ||
| verifiedRequest = await this._authentication.getVerifiedRequest(request, this._requireAccessToken); |
src/lib/Hub.ts
Outdated
| console.log(error); | ||
| return { | ||
| ok:false, | ||
| body: Buffer.from({errorCode: error}), |
There was a problem hiding this comment.
Buffer.from 파라미터는 string이 들어가야 합니다.
body: Buffer.from(JSON.stringify({errorCode: error})),
src/lib/interfaces/Store.ts
Outdated
| } | ||
| if(query.owner) { | ||
| requested = await requested | ||
| .Where('col.profile = :owner', {owner: query.owner}); |
src/lib/interfaces/Store.ts
Outdated
| } | ||
| if(query.objectId) { | ||
| requested = await requested | ||
| .Where('col.object = :objectId', {objectId: query.objectId}); |
src/lib/interfaces/Store.ts
Outdated
| .from(collections, 'col'); | ||
|
|
||
| if(query.type) { | ||
| requested = await requested |
There was a problem hiding this comment.
if(query.type) { requested.andWhere('col.type = :type', {type: query.type}); }
와 같이 변경하는것이 맞는 것 같음
line 181 ~ line 191 까지
src/lib/interfaces/Store.ts
Outdated
| .Where('col.object = :objectId', {objectId: query.objectId}); | ||
| } | ||
|
|
||
| requested = await requested |
There was a problem hiding this comment.
getMany() 를 이런식으로 뒤에 추가해주는건 안될 것 같음
query 중 하나를 픽스해서 where 하나를 필수로 걸고 거기에 getMany() 를 걸어놓고 나머지 조건에 대해서 andWhere()를 거는식으로 해야할듯
sweatpotato13
suggested changes
Dec 10, 2021
sweatpotato13
left a comment
sweatpotato13
left a comment
There was a problem hiding this comment.
코멘트 내용과 빌드시 에러 나오는건 수정을 해야할 것 같습니다.
커밋 올릴때는 기능 정상 동작 여부와 상관 없이 빌드가 가능한 상태로 올리는것이 좋습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[완료 사항]
[TODO]