Skip to content

Conversation

@otaly
Copy link

@otaly otaly commented Dec 2, 2024

Why

How

現象

  • Europe/LondonなどのUTC offsetが0のタイムゾーンのときにstartOfendOfで時間がズレる

参考

修正方法

iamkun#2264
上記PRの修正を適用しています

Test Plan

  • Unit Testを追加してあります
  • 本修正の適用でWhyに記載のバグが直ることを確認済みです

@otaly otaly self-assigned this Dec 2, 2024
@otaly otaly requested review from javascripter and km-tr and removed request for km-tr December 2, 2024 08:37
@otaly
Copy link
Author

otaly commented Dec 2, 2024

テストは通ったがcodecov(カバレッジ)で以下のエラー

/usr/local/lib/node_modules/codecov/lib/codecov.js:213
        var codecov_report_url = result.split('\n')[0]
                                        ^
TypeError: result.split is not a function

@javascripter
Copy link
Member

javascripter commented Dec 2, 2024

@otaly ar_nativeのアプリ側のjestでテストお願いします〜(バージョンアップ時に直ってそうならfork使うのやめるかもしれないので)

@otaly otaly merged commit 5963605 into dev Dec 16, 2024
0 of 4 checks passed
@otaly otaly deleted the issue-29382-utc-no-offset-bug branch December 16, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants