Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for boolean parameters in the parser. Key changes include adding a new add_bool method to the parser, implementing the parameter_bool class, and adding tests to verify its behavior.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_parameter_bool.cc | Adds tests to validate the boolean parameter functionality. |
| src/argparse/util.cc | Registers the new BOOL parameter type in create_parameter. |
| src/argparse/parser.cc | Implements the new add_bool method to handle boolean parameters. |
| src/argparse/parameter_bool.cc | Provides the implementation for parameter_bool's logic. |
| include/argparse/util.h | Updates header includes to reference parameter_bool. |
| include/argparse/parser.h | Declares the new add_bool function. |
| include/argparse/parameter_bool.h | Declares the parameter_bool class. |
| include/argparse/parameter.h | Updates the parameter_type enum to include BOOL. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.