-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add support for symfony/dotenv v6 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add test environment 8.1, 8.2 and 8.3
.travis.yml
Outdated
| - 8.1 | ||
| - 8.2 | ||
| - 8.3 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is actually dead and I obviously forgot to move the test to gh actions. Would you be up to help out with making that happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the gh actions and update PHPUnit.
I can't get the test "dumpReturnsFalseIfFileCannotBeWritten" to run on GitHub. This works well locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an error with docker mounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@helhum I can't get the unit test to run.
I really have no idea what it could be. I have tested vfsStream. Unfortunately this does not work with the Composer filesystem :(
Writing to the system temporary file system usingsys_get_temp_dir didn't work either.
Do you have an idea?
| "php": ">=7.2", | ||
| "composer-plugin-api": "^1.0 || ^2.0", | ||
| "symfony/dotenv": "^5.1" | ||
| "symfony/dotenv": "^5.1 || ^6.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check whether some API changed or has been deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. No change found
87f7b7f to
8329e82
Compare
a811b6b to
d08bd80
Compare
|
@websi Thanks a bunch so far. I think it makes sense that I take over from here as soon as possible |
|
Moved to #50 since I could not update this PR |
Add test environment 8.1, 8.2 and 8.3