Skip to content

Conversation

@websi
Copy link
Contributor

@websi websi commented Dec 6, 2023

Add test environment 8.1, 8.2 and 8.3

Add test environment 8.1, 8.2 and 8.3
.travis.yml Outdated
- 8.1
- 8.2
- 8.3

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is actually dead and I obviously forgot to move the test to gh actions. Would you be up to help out with making that happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the gh actions and update PHPUnit.

I can't get the test "dumpReturnsFalseIfFileCannotBeWritten" to run on GitHub. This works well locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an error with docker mounts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helhum I can't get the unit test to run.
I really have no idea what it could be. I have tested vfsStream. Unfortunately this does not work with the Composer filesystem :(
Writing to the system temporary file system usingsys_get_temp_dir didn't work either.

Do you have an idea?

"php": ">=7.2",
"composer-plugin-api": "^1.0 || ^2.0",
"symfony/dotenv": "^5.1"
"symfony/dotenv": "^5.1 || ^6.4"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether some API changed or has been deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. No change found

@websi websi force-pushed the dotenv_6 branch 6 times, most recently from 87f7b7f to 8329e82 Compare December 7, 2023 11:50
@websi websi force-pushed the dotenv_6 branch 3 times, most recently from a811b6b to d08bd80 Compare December 14, 2023 10:47
@helhum
Copy link
Owner

helhum commented Dec 20, 2023

@websi Thanks a bunch so far. I think it makes sense that I take over from here as soon as possible

@helhum
Copy link
Owner

helhum commented Jan 12, 2025

Moved to #50 since I could not update this PR

@helhum helhum closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants