WiP: Implement additional 3gpp message #15
Conversation
There was a problem hiding this comment.
Hi @ptitdoc, first of all, I would like to thank you for your effort by adding functionalities to Bromelia library, I really appreciate it. Find a few comments about your pull request. I would like to ask you to review it. Since you are working to add more functionalities, I thought it would be good to make some clarifications in order to help extending the lib. Any questions, do not hesitate to reach me out. Thanks!
|
Ok, I will review it. |
|
Hi @ptitdoc, I'm planning to integrate your changes into Bromelia. Did you manage to review comments above? If so, I would like to check it out. Otherwise, I will work on this to merge soon. Once again, thanks! |
|
Hello, sorry I'm not working actively on this project right now even-through I use it from time to time. I'm looking if I can at least commit your reviewed items right now. |
heimiricmr#15 Added AVPs Subscription-Data-Deletion, TS-Code, SS-Code and DSR-Flags
|
Hello, I think I fixed all your comments, I will try to be more strict with the documentation if I add new messages in the future. |
2 participants
Implementation of several missing 3gpp messages based on my own needs such as:
ISR
RSR/RSA
I will probably add additional messages on the coming weeks.