Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds integration support for the External API's "Get Latest Icing" endpoint, enabling clients to retrieve recent icing measurements for transmission lines. The changes also refactor existing DTOs by relocating them into a dedicated Dtos subfolder for better organization.
Changes:
- Added
GetLatestIcingAsyncmethod to the API client with support for unit system selection and optional time filtering - Created comprehensive DTO structure for icing data including maximum values and per-span/phase measurements
- Reorganized existing CurrentDto and ConductorTemperatureDto into a separate Dtos folder
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Program.cs | Added example usage demonstrating the new icing endpoint |
| UrlBuilder.cs | Added URL construction for the icing endpoint with query parameter support |
| HeimdallApiClient.cs | Implemented GetLatestIcingAsync method with documentation |
| LatestIcingResponse.cs | Created response wrapper containing icing measurements |
| LatestCurrentResponse.cs | Updated namespace import for relocated DTOs |
| LatestConductorTemperatureResponse.cs | Updated namespace import for relocated DTOs |
| SpanPhaseMeasurementResult.cs | Created DTO for individual span phase measurement with timestamp and unit |
| SpanPhaseIcingDto.cs | Created DTO for span phase icing data including ice weight, tension, and safety metrics |
| SpanIcingDto.cs | Created DTO for span-level icing data containing collection of span phases |
| MeasurementResult.cs | Created base DTO for measurement values with units |
| MaxIcingDto.cs | Created DTO for maximum icing values across all span phases |
| IcingDto.cs | Created root DTO containing maximum values and span collection |
| CurrentDto.cs | Moved to Dtos namespace folder |
| ConductorTemperatureDto.cs | Moved to Dtos namespace folder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dotnet/HeimdallPower.Api.Client/HeimdallPower.Api.Client/UrlBuilder.cs
Outdated
Show resolved
Hide resolved
joakimia
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: