Open
Conversation
added 11 commits
February 20, 2026 19:15
…ed metrics paths, copied walkthrough
Summary of ChangesHello @heidi-dang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new 'P6/doctor preflight' feature into the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the build configuration to include new core components and tests. However, it inadvertently includes a large volume of generated build artifacts, binaries, and dependency source code within the build/ directory. These files should be removed from the repository and managed via a .gitignore file to keep the repository clean and avoid environment-specific conflicts. Additionally, some improvements to the CMake configuration are recommended to improve portability and maintainability.
| @@ -0,0 +1,592 @@ | |||
| # This is the CMakeCache file. | |||
There was a problem hiding this comment.
The build/ directory contains generated files, Makefiles, and compiled binaries that are specific to your local environment. These should not be committed to version control. Please remove the build/ directory from the repository and add it to your .gitignore file.
Comment on lines
+40
to
+41
| crypto | ||
| pthread |
There was a problem hiding this comment.
Instead of linking crypto and pthread directly, it is better practice to use find_package to locate these libraries. For example, use find_package(Threads REQUIRED) and link against Threads::Threads. For crypto, use find_package(OpenSSL REQUIRED) and link against OpenSSL::Crypto. This ensures that the correct include paths and linker flags are used across different platforms.
Comment on lines
+20
to
+29
| heidi_engine/cpp/core/core.cpp | ||
| heidi_engine/cpp/core/clock.cpp | ||
| heidi_engine/cpp/core/config.cpp | ||
| heidi_engine/cpp/core/journal_writer.cpp | ||
| heidi_engine/cpp/core/run_id.cpp | ||
| heidi_engine/cpp/core/status_writer.cpp | ||
| heidi_engine/cpp/core/subprocess.cpp | ||
| heidi_engine/cpp/core/mock_provider.cpp | ||
| heidi_engine/cpp/core/async_collector.cpp | ||
| heidi_engine/cpp/core/manifest.cpp |
There was a problem hiding this comment.
Many core source files are duplicated between the heidid daemon and the unit tests. Consider creating a static library for these core components to avoid repeating the file list and to ensure consistent compilation settings across targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.