Conversation
added 12 commits
February 20, 2026 19:15
…ed metrics paths, copied walkthrough
Summary of ChangesHello @heidi-dang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the build configuration for the C++ daemon and its associated unit tests. It integrates new core C++ functionalities, likely related to keystore enforcement, and expands the testing suite to cover asynchronous operations and other core components. The changes ensure that the new features are properly compiled and tested within the project's build system. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant changes by adding core engine components and their corresponding tests. The CMake build files have been updated to include new source files and link necessary libraries like crypto and pthread. My review focuses on improving the maintainability of the CMakeLists.txt file and points out a critical issue with committing generated build files to the repository.
Comment on lines
+19
to
+29
| heidi_engine/cpp/daemon/daemon.cpp | ||
| heidi_engine/cpp/core/core.cpp | ||
| heidi_engine/cpp/core/clock.cpp | ||
| heidi_engine/cpp/core/config.cpp | ||
| heidi_engine/cpp/core/journal_writer.cpp | ||
| heidi_engine/cpp/core/run_id.cpp | ||
| heidi_engine/cpp/core/status_writer.cpp | ||
| heidi_engine/cpp/core/subprocess.cpp | ||
| heidi_engine/cpp/core/mock_provider.cpp | ||
| heidi_engine/cpp/core/async_collector.cpp | ||
| heidi_engine/cpp/core/manifest.cpp |
There was a problem hiding this comment.
For better maintainability, it's a good practice to keep the list of source files sorted alphabetically. This makes it easier to find files and see what has changed.
heidi_engine/cpp/core/async_collector.cpp
heidi_engine/cpp/core/clock.cpp
heidi_engine/cpp/core/config.cpp
heidi_engine/cpp/core/core.cpp
heidi_engine/cpp/core/journal_writer.cpp
heidi_engine/cpp/core/manifest.cpp
heidi_engine/cpp/core/mock_provider.cpp
heidi_engine/cpp/core/run_id.cpp
heidi_engine/cpp/core/status_writer.cpp
heidi_engine/cpp/core/subprocess.cpp
heidi_engine/cpp/daemon/daemon.cpp
Comment on lines
54
to
+65
| tests/test_cpp_core.cpp | ||
| tests/test_cpp_async.cpp | ||
| heidi_engine/cpp/core/clock.cpp | ||
| heidi_engine/cpp/core/run_id.cpp | ||
| heidi_engine/cpp/core/config.cpp | ||
| heidi_engine/cpp/core/journal_writer.cpp | ||
| heidi_engine/cpp/core/status_writer.cpp | ||
| heidi_engine/cpp/core/subprocess.cpp | ||
| heidi_engine/cpp/core/mock_provider.cpp | ||
| heidi_engine/cpp/core/async_collector.cpp | ||
| heidi_engine/cpp/core/core.cpp | ||
| heidi_engine/cpp/core/config.cpp | ||
| heidi_engine/cpp/core/clock.cpp | ||
| heidi_engine/cpp/core/run_id.cpp | ||
| heidi_engine/cpp/core/rlimit.cpp | ||
| heidi_engine/cpp/core/manifest.cpp |
There was a problem hiding this comment.
For better maintainability, it's a good practice to keep the list of source files sorted alphabetically. This makes it easier to find files and see what has changed.
heidi_engine/cpp/core/async_collector.cpp
heidi_engine/cpp/core/clock.cpp
heidi_engine/cpp/core/config.cpp
heidi_engine/cpp/core/core.cpp
heidi_engine/cpp/core/journal_writer.cpp
heidi_engine/cpp/core/manifest.cpp
heidi_engine/cpp/core/mock_provider.cpp
heidi_engine/cpp/core/run_id.cpp
heidi_engine/cpp/core/status_writer.cpp
heidi_engine/cpp/core/subprocess.cpp
tests/test_cpp_async.cpp
tests/test_cpp_core.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.