Conversation
benbrittain
force-pushed
the
push-vmlotklnppwq
branch
from
5464edf to
46223f6
Compare
Liam-DeVoe
left a comment
Liam-DeVoe
left a comment
There was a problem hiding this comment.
Thanks Benjamin! Appreciate the great patch.
I found the following patch notes helpful when reviewing this PR:
- https://github.com/rust-random/rand_core/releases/tag/v0.10.0
- https://github.com/rust-random/rand/releases/tag/0.10.0
I also had a long conversation with claude that convinced me the rust ecosystem has implicitly adopted the following policy: say A depends on B and exposes some types from B in its public API. If B releases a breaking version, A is expected to update to the latest B version unconditionally. Unlike Python, where I might support years of old dependency versions (Hypothesis does this, at moderate effort to us as maintainers but great benefit to our users), Rust expects the ecosystem to move to the latest version of its dependencies basically immediately.
I found https://github.com/dtolnay/semver-trick and the "libcpocalypse" mentioned there especially helpful as context.
(I'm sure this is all obvious to long-time rust experts!)
| impl TryRng for HegelRandom { | ||
| type Error = Infallible; | ||
|
|
||
| fn try_next_u32(&mut self) -> Result<u32, Self::Error> { |
There was a problem hiding this comment.
self-note: RngCore (renamed Rng) can't be impl'd anymore. Instead you are meant to impl TryRng with type Error = Infallible. rust-random/rand_core#45
Liam-DeVoe
left a comment
Liam-DeVoe
left a comment
There was a problem hiding this comment.
Forgot one comment! Happy to merge once that's addressed.
| - concisely describe any public-facing changes, and why. Internal-only changes can be documented as e.g. "This release improves an internal invariant." | ||
| - use `single backticks` for verbatim code. | ||
|
|
||
| After the pull request is merged, the contents of this file (except the first line) are automatically added to `CHANGELOG.md`. More examples can be found in that file. |
There was a problem hiding this comment.
| After the pull request is merged, the contents of this file (except the first line) are automatically added to `CHANGELOG.md`. More examples can be found in that file. | |
| RELEASE_TYPE: patch | |
| This patch upgrades [`rand`](https://crates.io/crates/rand) to `0.10` in our `rand` feature. | |
| Thanks to Benjamin Brittain for this patch! |
No need to include the explanatory text :). I also changed to patch, because a minor version bump (which is equivalent to a major version bump while we are in beta; see) felt excessive for an opt-in feature, even if it is strictly speaking a breaking change.
Feel free to remove the attribution or change to your github handle if you prefer 🙂
2 participants
No description provided.