Forward #[rule] and #[invariant] attributes#155
Conversation
DRMacIver
left a comment
DRMacIver
left a comment
There was a problem hiding this comment.
This generally looks fine to me except that I found that the release notes were completely inscrutable and I had to do a bunch of issue chasing to figure out what this was about. I'd appreciate an example or other clarification of the problem in the release notes.
|
I actually think this is a reasonably readable changelog to rust natives, because "attribute" is a specific rust glossary definition. But I've added an example |
It was actually "forwarding" that threw me rather than "attribute"! |
| - name: Check lint | ||
| run: just check-lint | ||
| - name: Check Zizmor | ||
| - name: Check zizmor |
There was a problem hiding this comment.
This doesn't matter, but why was this lower-cased here?
There was a problem hiding this comment.
oops this was a local change I hadn't meant to bundle here. I just noticed at some point that all our step names were Sentence case even for proper nouns, and changed it without thinking too much. It totally doesn't matter and I'm fine reverting this
There was a problem hiding this comment.
I'm fine either way, feel free to leave it in if you prefer.
2 participants
Closes #151.