Add support for alphabet in {"type": "string"}#72
Open
Liam-DeVoe wants to merge 10 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Here's a problem I ran into: cbor uses UTF-8 to encode strings. UTF-8 disallows surrogate code points. We want to be able to generate surrogate code points, because some languages use UTF-16 or raw bytes as their string representation. Therefore the protocol must be able to transport surrogate code points.
I chose to change the representation of all strings in the protocol to a new tag
6, which represents it as WTF-8, which is byte-for-byte equivalent to UTF-8 except it relaxes the UTF-8 well-formed requirement that surrogate code points not appear. Tags 6-15 are reserved for local assignment in the cbor spec.Every client library will need to understand this and implement a decoder for tag 6. I considered only encoding as tag 6 when a surrogate is present, but I think unifying the representation and forcing libraries to contend with this early is the right choice.