Exercises lesson5 - Cesar#26
Open
cesarsantiagonunez wants to merge 6 commits intohectorcanto:mainfrom
Open
Conversation
merge main in exercises_lesson5
hectorcanto
approved these changes
Nov 20, 2022
Owner
hectorcanto
left a comment
hectorcanto
left a comment
There was a problem hiding this comment.
Ben, pero había marxe para máis no exercicio 2. O primeiro ben
| ENV LESSON_NUMBER=5 | ||
| EXPOSE 80 | ||
|
|
||
| RUN mv /etc/nginx/nginx.conf /etc/nginx/default.conf |
Owner
There was a problem hiding this comment.
por que fas isto? para gardar o orixinal?
| ### Your changes | ||
|
|
||
| - Combine lines 4 and 5 | ||
| - Replace line 8 with **ADD hello.zip** |
Owner
There was a problem hiding this comment.
Diría que COPY e ADD ocupan o mesmo, non? eu diría de facer o unzip fora, aforras operaciónes e capas
| @@ -11,3 +11,6 @@ Edit the Dockerfile and/or write below your thoughts. Open a pull request with y | |||
|
|
|||
| ### Your changes | |||
Owner
There was a problem hiding this comment.
Poderîas ter engadido máis cousas:
- cambiar a imaxe a lago máis minimalista (p.e. alpine), incluso unha imaxe que corra o binario e punto
- Facer un multistage para librarte do lixo que xera APT
- APT sen cache
- Borrar o zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.