Update django-livefield to poetry#64
Merged
cnotbohm merged 3 commits intohearsaycorp:masterfrom Mar 4, 2026
Merged
Conversation
cnotbohm
commented
Mar 4, 2026
| @@ -0,0 +1,89 @@ | |||
| name: Client Build, Publish, and Release | |||
Contributor
Author
There was a problem hiding this comment.
This action follows our old process, publish to pypi first, then create a github release, but does it all manually for us
only users with write access to the repo will be able to call the action
cnotbohm
commented
Mar 4, 2026
Comment on lines
+18
to
+48
| matrix: | ||
| python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | ||
| django-version: ['3.2', '4.0', '4.1', '4.2', '5.0'] | ||
| services: | ||
| postgres: | ||
| image: postgres:12 | ||
| ports: | ||
| - 5432:5432 | ||
| options: >- | ||
| --health-cmd=pg_isready | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=5 | ||
| env: | ||
| POSTGRES_DB: testdb | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_PASSWORD: postgres | ||
| mysql: | ||
| image: mysql:8 | ||
| ports: | ||
| - 3306:3306 | ||
| options: >- | ||
| --health-cmd="mysqladmin ping" | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=5 | ||
| env: | ||
| MYSQL_USER: travis | ||
| MYSQL_PASSWORD: travis | ||
| MYSQL_ALLOW_EMPTY_PASSWORD: true | ||
| MYSQL_DATABASE: test_testdb |
Contributor
Author
There was a problem hiding this comment.
runs the tests the same as the repo did before
cnotbohm
commented
Mar 4, 2026
Comment on lines
+11
to
+31
| def _db_settings(): | ||
| db_engine = os.environ.get("DJANGO_DB_ENGINE", "sqlite") | ||
| if db_engine == "mysql": | ||
| return { | ||
| "ENGINE": "django.db.backends.mysql", | ||
| "NAME": os.environ["DJANGO_DB_NAME"], | ||
| "USER": os.environ["DJANGO_DB_USER"], | ||
| } | ||
| if db_engine == "postgres": | ||
| return { | ||
| "ENGINE": "django.db.backends.postgresql", | ||
| "NAME": os.environ["DJANGO_DB_NAME"], | ||
| "USER": os.environ["DJANGO_DB_USER"], | ||
| } | ||
| if db_engine == "sqlite": | ||
| return { | ||
| "ENGINE": "django.db.backends.sqlite3", | ||
| "NAME": os.path.join(REPO_ROOT, "database.db"), | ||
| } | ||
|
|
||
| raise ValueError(f"Unknown DB engine: {db_engine}") |
Contributor
Author
There was a problem hiding this comment.
this sets up a mock DB the same way setup.py did before
limelator
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repo to poetry for build, testing, and publishing.
It also updates documents to be in MD formate
A future PR will then update the repo to have python 3.14 support and Django 5.2 support