Add Flake support

[lomenzel]

This repository is quite out of date. With a flake.nix it can be imported in nixos-unstable or a newer release with pkgs for shabitica pinned at 21.05

i also changed git:// to https:// in the generated file for the node packages.

fixes #11

[aszlig]

I'm all in support for this, just don't want to add unnecessary dependencies as commented. Will change the Hydra channel to the Flake.

[aszlig]

Thanks, jobset added at https://hydra.build/jobset/shabitica/master, right now there aren't any hydraJobs so it doesn't yet evaluate.

[aszlig]

Btw. this is not how nixosModules is supposed to work with Flakes, because the system attribute is implied by the current NixOS configuration rather than an individual module.

[lomenzel]

changed it to inputs.shabitica.nixosModules.default

[lomenzel]

the go-camo package had the problem that 25.5 will depricate buildGoPackage so i passed the pkgs from the default module to imageproxy. dont know if its the cleanest way

[aszlig]

The default.nix in the project root is for supporting Hydra channels, so you can just boil it down to the module entrypoint:

Suggested change

	nixosModules.default = { lib, config, ... }: {
	imports = [
	(import ./default.nix {
	inherit lib config;
	pkgs = import nixpkgs {
	inherit (config.nixpkgs.localSystem) system;
	};
	})
	];
	};
	nixosModules.default.imports = [ ./modules ];

[aszlig]

Why are you doing this?

Providing the module as an attribute set shouldn't be needed here because it is already a NixOS module.

Even if it would not be a NixOS module, providing a module as an attribute set like this would miss the key attribute which makes errors less readable since the module name is missing.

[lomenzel]

because else it would default to the pkgs defined by the user for the rest of the system, but for example pkgs.buildGoPackage is depricated and removed in newer channels so it has to use the 21.05 channel

[aszlig]

because else it would default to the pkgs defined by the user for the rest of the system, but for example pkgs.buildGoPackage is depricated and removed in newer channels so it has to use the 21.05 channel

Yeah, noticed that already, see my comment below.

[aszlig]

If I'd look at this from a beginner perspective: Where does the inputs attribute come from? Is it a module argument? Is it from another Flake?

[aszlig]

the go-camo package had the problem that 25.5 will depricate buildGoPackage so i passed the pkgs from the default module to imageproxy. dont know if its the cleanest way

Ah, that explains why you passed the module as an attribute set. This however not only has the mentioned issues but also makes it hard to change the module (eg. if the module no longer is a function, we'd need to change the import).

I'd instead add another internal option, eg. shabitica.pinnedPkgs and pass it via the flake's module definition. That way we can not only use it for the go-camo case but also for eg. Node.js 10, which I'm pretty sure won't work on newer NixOS releases.

[lomenzel]

I'd instead add another internal option, eg. shabitica.pinnedPkgs and pass it via the flake's module definition.

thats defenitly a better idea 💡

[lomenzel]

ok now i messed it up completely. trying to rebuild the system now throws:

 error: Please be informed that this pseudo-package is not the only part of
       Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
       without some special measures to handle failing packages, like those taken
       by Hydra.

[lomenzel]

still does not work