missing comma; add patsy requirements from requirements.txt#112
Open
harrisonritz wants to merge 1 commit intohddm-devs:masterfrom
Open
missing comma; add patsy requirements from requirements.txt#112harrisonritz wants to merge 1 commit intohddm-devs:masterfrom
harrisonritz wants to merge 1 commit intohddm-devs:masterfrom
Conversation
AlexanderFengler
approved these changes
Feb 23, 2024
Contributor
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
The comma was a bug, patsy will install to 0.5... something either way, but no issue with making version specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py installfails because of missing commapatsydidn't have requirements, so matched torequirements.txt. if this was blank for a good reason, then feel free to ignore.Can't test PR because can't install hddm.