feat(factorio-cycle-calculator): Use Generated Data Models#117
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Factorio cycle calculator app to use generated (datamodel-code-generator) dataclass models for data-raw-dump.json, and adjusts repo tooling/config to accommodate the generated code.
Changes:
- Add a
devdependency group fordatamodel-code-generator[ruff]and updateuv.lockaccordingly. - Refactor the app’s data-raw parsing to build/use a typed
FactorioDataRawcontainer and generated prototype dataclasses. - Exclude
**/generated/**from various linters/hooks and adjust VS Code Python analysis settings.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds locked dependencies for datamodel-code-generator and its toolchain (e.g., black/isort/argcomplete). |
src/private/app/factorio-cycle-calculator/pyproject.toml |
Introduces a dev dependency group for the code generator. |
src/private/app/factorio-cycle-calculator/app.py |
Loads generated models and migrates parsing/access to dataclass-backed prototypes; refactors solver constraint construction. |
hk.pkl |
Excludes generated/ from hk-based tooling exclude list. |
.typos.toml |
Excludes generated/ from typos scanning. |
.pre-commit-config.yaml |
Regenerated to exclude generated/ in relevant hooks. |
.vscode/settings.json |
Disables Python type checking (workspace-wide). |
src/private/app/factorio-cycle-calculator/schema/.gitkeep |
No functional change; keeps the schema directory present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3b7d272f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hcoona
force-pushed
the
dev/shuaizhang/factorio-calculator-use-jsonschema
branch
from
6b3b7d2 to
628391f
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
No description provided.