-
Notifications
You must be signed in to change notification settings - Fork 2
Add JSON editor, canvas area and upload button #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
You should add more description to what you have done in this pull request, talking about files you've changed and why you did. |
|
in the description of the pull request ? |
|
نعم، و أيضاً يجب عليك حل التضارب الموجود في الكود قبل أن يتم دمجه |
|
|
I've changed the title of the pull request that it would be more meaningful and by way for versioning your releases I think you should read semantic versioning - you should start with |
|
yes There are some conflicts please pull the latest code version then merge changes locally then do another pull request |
|
Okay , but what are the conflicts you found ? |
|
It's an automatic message generated by github at the end of this discussion just above the comment box saying that |
In this Version :
divide the app page into
1 - JSON Editor
2 - Canvas Area
3 - Buttons to upload the data file