Skip to content

test: skip node-fetch and @whatwg-node/fetch tests on Node 21+ #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleclarson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: skip node-fetch and @whatwg-node/fetch tests on Node 21+ #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions testbed/basic/ci.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,17 @@ if (process.env.CI === "true") {
platform: "node",
command: "node --experimental-fetch entry-node-native-fetch.js",
},
{
// The --no-experimental-fetch flag is only available on Node 20 and below. Since node-fetch and
// @whatwg-node/fetch are only used when native fetch is not available, we can skip them on Node
// 21 and above.
nodeVersionMajor < 21 && {
name: "Node with node-fetch",
platform: "node",
command: `node ${noFetchFlag} entry-node.js`,
skipCryptoTest: nodeVersionMajor < 16,
skipMultipartTest: true, // node-fetch doesn't support streaming request bodies
},
{
nodeVersionMajor < 21 && {
name: "Node with @whatwg-node/fetch",
platform: "node",
command: `node ${noFetchFlag} entry-node-whatwg.js`,
Expand Down