Skip to content

Correctly centering text on rectangular devices #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatl merged 1 commit into from
Jul 20, 2025
Merged

Correctly centering text on rectangular devices #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions widget/source/Entities/EntityListView.mc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class EntityListView extends Ui.View {
// Adjust text position for rectangular screens
if (Utils.isRectangularScreen()) {
dc.setColor(Graphics.COLOR_WHITE, Graphics.COLOR_BLACK);
dc.drawText(vh * 0.65, cvw, font, text, Graphics.TEXT_JUSTIFY_CENTER);
dc.drawText(cvw, vh * 0.4, font, text, Graphics.TEXT_JUSTIFY_CENTER);
Copy link
Author

@alexpetroaica alexpetroaica Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs, the width is the first argument, not the height, which was causing some trouble (see screenshots i added to the PR)

} else {
dc.setColor(Graphics.COLOR_WHITE, Graphics.COLOR_BLACK);
dc.drawText(cvh, cvw, font, text, Graphics.TEXT_JUSTIFY_CENTER);
Copy link
Author

@alexpetroaica alexpetroaica Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to touch this one because I assumed you tested on non-rectangular devices, but it should probably be fixed too as the arguments are passed the wrong way around

Expand Down Expand Up @@ -212,7 +212,7 @@ class EntityListView extends Ui.View {

// Adjust text position for rectangular screens
if (Utils.isRectangularScreen()) {
dc.drawText(cvh, cvw, font, text, Graphics.TEXT_JUSTIFY_CENTER);
dc.drawText( cvw, cvh, font, text, Graphics.TEXT_JUSTIFY_CENTER);
} else {
dc.drawText(cvh, cvw * 1.1, font, text, Graphics.TEXT_JUSTIFY_CENTER);
}
Expand Down