fix directories not being ignored for upload when running build #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpx7
approved these changes
Sep 5, 2025
zlangbert
force-pushed
the
fix-build-ignore
branch
from
2961a93 to
ae65b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directories specified in .gitignore were not being properly ignored (though files were). Whether that was a bug in
github.com/monochromegane/go-gitignoreor our use of it I don't know. But that package has not been maintained for 5 years.Replaced it with https://github.com/boyter/gocodewalker which does essentially the same thing but is currently maintained. Tested with this new implementation and both files and directories are properly excluded from the tarball.